cgit-70/cache.c, branch v0.6

cache_safe_filename() needs more buffers

2007-05-18T20:51:02+00:00

The single static buffer makes it impossible to use the result of two
different calls to this function simultaneously. Fix it by using 4
buffers.

Signed-off-by: Lars Hjemli

Enable url=value querystring parameter

2007-05-18T20:51:01+00:00

This makes is possible to use repo-urls like '/pub/scm/git/git.git' and
even add path specifications, like '/pub/scm/git/git.git/log/documentation'.

Signed-off-by: Lars Hjemli

Remove troublesome chars from cachefile names

2007-01-11T23:24:35+00:00

Add a funtion cache_safe_filename() which replaces possibly bad filename
characters with '_'.

Signed-off-by: Lars Hjemli

Move cache_prepare() to cgit

2007-01-11T23:00:15+00:00

This moves some cgit-specific stuff away from cache.c

Signed-off-by: Lars Hjemli

Allow relative paths for cgit_cache_root

2006-12-16T12:55:58+00:00

Make sure we chdir(2) back to the original getcwd(2) when a page
has been generated. Also, if the cgit_cache_root do not exist,
try to create it.

This is a feature intended to ease testing/debugging.

Signed-off-by: Lars Hjemli

cache_lock: do xstrdup/free on lockfile

2006-12-12T09:16:41+00:00

Since fmt() uses 8 alternating static buffers, and cache_lock might call
cache_create_dirs() multiple times, which in turn might call fmt() twice,
after four iterations lockfile would be overwritten by a cachedirectory
path.

In worst case, this could cause the cachedirectory to be unlinked and replaced
by a cachefile.

Fix: use xstrdup() on the result from fmt() before assigning to lockfile, and
call free(lockfile) before exit.

Signed-off-by: Lars Hjemli

Don't truncate valid cachefiles

2006-12-11T21:53:50+00:00

An embarrassing thinko in cgit_check_cache() would truncate valid cachefiles
in the following situation:
  1) process A notices a missing/expired cachefile
  2) process B gets scheduled, locks, fills and unlocks the cachefile
  3) process A gets scheduled, locks the cachefile, notices that the cachefile
     now exist/is not expired anymore, and continues to overwrite it with an
     empty lockfile.

Thanks to Linus for noticing (again).

Signed-off-by: Lars Hjemli

Avoid infinite loops in caching layer

2006-12-11T11:10:12+00:00

Add a global variable, cgit_max_lock_attemps, to avoid the possibility of
infinite loops when failing to acquire a lockfile. This could happen on
broken setups or under crazy server load.

Incidentally, this also fixes a lurking bug in cache_lock() where an
uninitialized returnvalue was used.

Signed-off-by: Lars Hjemli

Fix cache algorithm loophole

2006-12-11T08:57:58+00:00

This closes the door for unneccessary calls to cgit_fill_cache().

Noticed by Linus.

Signed-off-by: Lars Hjemli

Add license file and copyright notices

2006-12-10T21:41:14+00:00

Signed-off-by: Lars Hjemli